Re: [Xen-devel] [PATCH 1/5] xen/arm: Introduce enable callback to enable a capabilities on each online CPU

[Julien Grall <julien.grall@xxxxxxxxxx>]

Hi Lars,

On 17/01/18 12:23, Lars Kurth wrote:
> > On 17 Jan 2018, at 10:31, Julien Grall <julien.grall@xxxxxxxxxx 
> > <mailto:julien.grall@xxxxxxxxxx>> wrote:
> > Hi Stefano,
> >
> > On 16/01/18 23:55, Stefano Stabellini wrote:
> > > On Tue, 16 Jan 2018, Julien Grall wrote:
> > > > Once Xen knows what features/workarounds present on the platform, it
> > > > might be necessary to configure each online CPU.
> > > >
> > > > Introduce a new callback "enable" that will be called on each online 
> > > > CPU to
> > > > configure the "capability".
> > > >
> > > > The code is based on Linux v4.14 (where cpufeature.c comes from), the
> > > > explanation of why using stop_machine_run is kept as we have similar
> > > > problem in the future.
> > > >
> > > > Lastly introduce enable_errata_workaround that will be called once CPUs
> > > > have booted and before the hardware domain is created.
> > > >
> > > > This is part of XSA-254.
> > > >
> > > > Signed-of-by: Julien Grall <julien.grall@xxxxxxxxxx 
> > > > <mailto:julien.grall@xxxxxxxxxx>>
> > > If you took the code from Linux, you need to add the original
> > > Signed-off-by from the Linux commit. Aside from that:
> > There are multiple commits touching this function. So I followed what 
> > we did in similar situation. By that I mean, mentioning the code was 
> > taken from Linux and not gathered the signed-off-by.
> > If you really want, I can gather all the signed-off-by of the commit 
> > touching this function.
> If there are a lot of then, you may want to consider adding 
> a README.source file instead. There are a few examples in tree and they 
> are also mentioned in CONTRIBUTING files
I am not sure to understand your suggestion here. I spotted only one 
CONTRIBUTING file and it only list the license.
Regarding README.source, this is covering file and contain the same 
mention as in the commit message. As this is a single function. Isn't 
the commit message enough?
Lastly, we do have quite a bit of code in Xen coming from Linux (or 
other project). A lot of them are not listed in 
README.source/CONTRIBUTING. But only mention in the commit message (not 
necessarily with Signed-off-by tag).
So I am quite interested to know what is the normal procedure here.

Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel