Re: [Xen-devel] [PATCH v2 5/7] x86: relocate pvh_info

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Mon, Jan 22, 2018 at 12:44:41PM +0000, Roger Pau Monné wrote:
> On Mon, Jan 22, 2018 at 12:35:21PM +0000, Wei Liu wrote:
> > To avoid spamming the list with all the other acked patches, here is the
> > updated patch.
> > 
> > ---8<---
> > From 1ac0afbbc0ecd620c5fba3a03bb084bc4dafc78e Mon Sep 17 00:00:00 2001
> > From: Wei Liu <wei.liu2@xxxxxxxxxx>
> > Date: Wed, 17 Jan 2018 18:38:02 +0000
> > Subject: [PATCH] x86: relocate pvh_info
> > MIME-Version: 1.0
> > Content-Type: text/plain; charset=UTF-8
> > Content-Transfer-Encoding: 8bit
> > 
> > Modify early boot code to relocate pvh info as well, so that we can be
> > sure __va in __start_xen works.
> > 
> > Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>
> 
> Reviewed-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> 
> With one question below.
> 
> > diff --git a/xen/arch/x86/boot/head.S b/xen/arch/x86/boot/head.S
> > index 0f652cea11..aa2e2a93c8 100644
> > --- a/xen/arch/x86/boot/head.S
> > +++ b/xen/arch/x86/boot/head.S
> > @@ -414,6 +414,7 @@ __pvh_start:
> >  
> >          /* Set trampoline_phys to use mfn 1 to avoid having a mapping at 
> > VA 0 */
> >          movw    $0x1000, sym_esi(trampoline_phys)
> > +        movl    (%ebx), %eax /* mov $XEN_HVM_START_MAGIC_VALUE, %eax */
> 
> Do you really need the l suffix here?

I guess no. I copied it from your previous reply. ;-)

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel