Re: [Xen-devel] [PATCH v5] x86: relocate pvh_info

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Tue, Jan 23, 2018 at 03:18:22PM +0000, Andrew Cooper wrote:
> On 23/01/18 15:13, Wei Liu wrote:
> > @@ -226,14 +259,27 @@ static multiboot_info_t *mbi2_reloc(u32 mbi_in)
> >      return mbi_out;
> >  }
> >  
> > -multiboot_info_t __stdcall *reloc(u32 mb_magic, u32 mbi_in, u32 trampoline)
> > +void __stdcall *reloc(u32 magic, u32 in, u32 trampoline)
> 
> As an final observation, void * __stdcall reloc() so the __stdcall isn't
> in the middle of the return type (Can be fixed on commit).

Sure.

> 
> Otherwise, Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

Thanks.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel