Re: [Xen-devel] [PATCH 1/4 v3 for-4.10] libxl: Fix the bug introduced in commit "libxl: use correct type modifier for vuart_gfn"

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Tue, Nov 14, 2017 at 01:56:11PM +0000, Wei Liu wrote:
> On Tue, Nov 14, 2017 at 05:12:26PM +0530, Bhupinder Thakur wrote:
> > Hi,
> > 
> > On 14 Nov 2017 3:35 pm, "Wei Liu" <wei.liu2@xxxxxxxxxx> wrote:
> > 
> > > On Mon, Nov 13, 2017 at 03:56:23PM +0000, Julien Grall wrote:
> > > > Hi Wei,
> > > >
> > > > Sorry I missed that e-mail.
> > > >
> > > > On 10/31/2017 10:07 AM, Wei Liu wrote:
> > > > > Change the tag to for-4.10.
> > > > >
> > > > > Julien, this is needed to fix vuart emulation.
> > > >
> > > > To confirm, only patch #1 is candidate for Xen 4.10, right? The rest
> > > will be
> > > > queued for Xen 4.11?
> > > >
> > >
> > > I think so.
> > >
> > > Bhupinder, can you confirm that?
> > >
> > 
> > Yes. Only first patch is required for fixing the compilation issue.
> > 
> 
> Thanks. I will commit the first patch and put the rest in my for-next
> queue.

OK, patch 2 to 4 applied cleanly but the build is broken by them.

libxl_console.c: In function ‘libxl__device_console_add’:
libxl_console.c:332:68: error: ‘libxl__domain_build_state {aka struct 
<anonymous>}’ has no member named ‘console_mfn’; did you mean ‘console_gfn’?
         flexarray_append(ro_front, GCSPRINTF("%"PRIu_xen_pfn, 
state->console_mfn));
                                                                    ^
libxl_internal.h:3921:58: note: in definition of macro ‘GCSPRINTF’
 #define GCSPRINTF(fmt, ...) (libxl__sprintf((gc), (fmt), __VA_ARGS__))
                                                          ^~~~~~~~~~~

For now I've dropped this series.

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel