Re: [Xen-devel] [PATCH] xen/VT-d: Remove the use of __LINE__ from IOMMU_WAIT_OP()

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 24/01/18 15:41, Jan Beulich wrote:
>>>> On 24.01.18 at 15:11, <andrew.cooper3@xxxxxxxxxx> wrote:
>> The use of __LINE__ in printk()'s is problematic for livepatching, as it 
>> tends
>> to cause unnecessary binary differences.
>>
>> Take this opportunity to provide some rather more useful information than 
>> just
>> file/line/func in the form of the full register/stack trace leading to the
>> problem (which I've needed in the past for debugging).
>>
>> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
>
>> --- a/xen/drivers/passthrough/vtd/dmar.h
>> +++ b/xen/drivers/passthrough/vtd/dmar.h
>> @@ -117,8 +117,10 @@ do {                                                \
>>              break;                                  \
>>          if ( NOW() > start_time + DMAR_OPERATION_TIMEOUT ) {    \
>>              if ( !kexecing )                                    \
>> -                panic("%s:%d:%s: DMAR hardware is malfunctional",\
>> -                      __FILE__, __LINE__, __func__);            \
>> +            {                                                   \
>> +                dump_execution_state();                         \
>> +                panic("DMAR hardware malfunction");             \
>> +            }                                                   \
>>              else                                                \
>>                  break;                                          \
> Perhaps a good opportunity to take out the pointless "else" as well?

Can do (although I'm not going to repost for just that).

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel