Re: [Xen-devel] [PATCH RFC] ocaml: Fix compile with ocaml 4.06, use unsafe strings

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 26/01/18 11:43, Wei Liu wrote:
> On Fri, Jan 26, 2018 at 09:29:20AM +0000, Christian Lindig wrote:
>>
>>> On 26. Jan 2018, at 09:09, M A Young <m.a.young@xxxxxxxxxxxx> wrote:
>>>
>>> On Fri, 26 Jan 2018, John Thomson wrote:
>>>
>>>> Use autoconf to test if ocaml version >= 4.02
>>>> If so, use -unsafe-string for ocamlopt and ocamlc
>>>>
>>>> Bytes & safe-string were introduced in ocaml 4.02 (2015-07-27)
>>>>
>>>> With ocaml 4.06, -safe-string is now default
>>>> This separates the types bytes (mutable string) and string
>>> For Fedora Rawhide, which has ocaml 4.06, we came up with a patch to make 
>>> xen ocaml safe-strings compliant (which I haven't got around to submitting 
>>> to this list yet).
>>>
>>> The patch is at
>>> https://src.fedoraproject.org/rpms/xen/blob/master/f/xen.ocaml.safe-strings.patch
>>> with the related Fedora bug at
>>> https://bugzilla.redhat.com/show_bug.cgi?id=1526703
>>>
>>>     Michael Young
>> The patch looks good and I would prefer to take it than to use 
>> -unsafe-string which isn’t a solution in the long run.
>>
> Hi Christian
>
> Is that an ack?
>
> Could you please in future explicitly give an Acked-by or Reviewed-by
> tag so that committers know they can apply the proposed patch directly?

Also, is this patch compatible with Ocaml 3.09.3?  If not, either the
fix or the minimum version of Ocaml needs suitably adjusting.

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel