Re: [Xen-devel] [PATCH] x86/boot: Make the "Building Dom0" messages consistent

[Roger Pau Monné <roger.pau@xxxxxxxxxx>]

On Fri, Jan 26, 2018 at 04:00:03PM +0000, Andrew Cooper wrote:
> Switch the PV message to match the wording of the PVH side, use the same
> number of ***'s, explicitly identify PV vs PVH, and set the log level at INFO.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

Reviewed-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>

> ---
> CC: Jan Beulich <JBeulich@xxxxxxxx>
> CC: Wei Liu <wei.liu2@xxxxxxxxxx>
> CC: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> ---
>  xen/arch/x86/hvm/dom0_build.c | 2 +-
>  xen/arch/x86/pv/dom0_build.c  | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/xen/arch/x86/hvm/dom0_build.c b/xen/arch/x86/hvm/dom0_build.c
> index 962dc14..bf7baa8 100644
> --- a/xen/arch/x86/hvm/dom0_build.c
> +++ b/xen/arch/x86/hvm/dom0_build.c
> @@ -1064,7 +1064,7 @@ int __init dom0_construct_pvh(struct domain *d, const 
> module_t *image,
>      paddr_t entry, start_info;
>      int rc;
>  
> -    printk("** Building a PVH Dom0 **\n");
> +    printk(XENLOG_INFO "*** Building a PVH Dom0 ***\n");
>  
>      iommu_hwdom_init(d);
>  
> diff --git a/xen/arch/x86/pv/dom0_build.c b/xen/arch/x86/pv/dom0_build.c
> index e7065bf..87b325c 100644
> --- a/xen/arch/x86/pv/dom0_build.c
> +++ b/xen/arch/x86/pv/dom0_build.c
> @@ -328,7 +328,7 @@ int __init dom0_construct_pv(struct domain *d,
>      /* Machine address of next candidate page-table page. */
>      paddr_t mpt_alloc;
>  
> -    printk("*** LOADING DOMAIN 0 ***\n");
> +    printk(XENLOG_INFO "*** Building a PV Dom0 ***\n");

Now that we have the shim this should probably be:

"*** Building a PV Dom%c ***\n", pv_shim ? 'U' : '0'

But in any case can be fixed in a subsequent commit.

Thanks, Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel