Re: [Xen-devel] [PATCH 2/3] x86/hvm: Improvements to external users of decode_register()

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 26.01.18 at 14:16, <andrew.cooper3@xxxxxxxxxx> wrote:
> * Rename to decode_gpr() to be more specific as to its purpose
> * Drop the highbyte encoding handling, as users care, and it unlikely that

"... as users don't care, and it's ..." or "... as no users care, and it's
..."?

> @@ -601,14 +609,23 @@ int x86_emulate_wrapper(
>  #define x86_emulate x86_emulate_wrapper
>  #endif
>  
> +/* Map GPRs by ModRM encoding to their offset within struct cpu_user_regs. */
> +extern const uint8_t cpu_user_regs_gpr_offsets[X86_NR_GPRS];

Okay, this explains why you don't want this array inside the
function.

With the description suitably corrected
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel