Re: [Xen-devel] [PATCH RFC v2 06/12] x86: add a xpti command line parameter

[Juergen Gross <jgross@xxxxxxxx>]

On 30/01/18 16:39, Jan Beulich wrote:
>>>> On 22.01.18 at 13:32, <jgross@xxxxxxxx> wrote:
>> @@ -212,6 +249,24 @@ int pv_domain_initialise(struct domain *d, unsigned int 
>> domcr_flags,
>>      /* 64-bit PV guest by default. */
>>      d->arch.is_32bit_pv = d->arch.has_32bit_shinfo = 0;
>>  
>> +    switch (opt_xpti)
> 
> Style.
> 
>> +    {
>> +    case XPTI_OFF:
>> +        d->arch.pv_domain.xpti = false;
>> +        break;
>> +    case XPTI_ON:
>> +        d->arch.pv_domain.xpti = true;
>> +        break;
>> +    case XPTI_NODOM0:
>> +        d->arch.pv_domain.xpti = boot_cpu_data.x86_vendor != X86_VENDOR_AMD 
>> &&
>> +                                 d->domain_id != 0 &&
>> +                                 d->domain_id != hardware_domid;
>> +        break;
>> +    case XPTI_DEFAULT:
>> +        d->arch.pv_domain.xpti = boot_cpu_data.x86_vendor != X86_VENDOR_AMD;
>> +        break;
>> +    }
> 
> Why does a 32-bit domain need this?

It doesn't. In my current version I have moved this initialization and
it will never run for 32 bit domains.


Juergen

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel