Re: [Xen-devel] [PATCH 03/10] arm64: Add ICV_BPR1_EL1 handler

[Julien Grall <julien.grall@xxxxxxxxxx>]

Hi Manish,

On 01/02/18 08:57, Manish Jaggi wrote:
> On 01/25/2018 10:14 PM, Julien Grall wrote:
> > Hi Manish,
> >
> > On 16/01/18 15:42, mjaggi@xxxxxxxxxxxxxxxxxx wrote:
> > > From: Manish Jaggi <manish.jaggi@xxxxxxxxxx>
> > >
> > > Add a handler for reading/writing the guest's view of the ICC_BPR1_EL1
> > > register, which is located in the ICH_VMCR_EL2.BPR1 field.
> > This commit (and likely the followings) is coming from Linux, right? 
> > If it matches commit from Linux, then you need to keep tags and point 
> > to the Linux commit. See commit 7762c2d6f4 in Xen as an example to how 
> > to do it.
> > If you make changes for Xen, then write "Adapted for Xen...".
> ok
> > But looking at the patch the major difference is you use Xen coding 
> > style. The rest is pretty much use Xen name for access register and 
> > adding missing define.
> > I think it would be beneficial for Xen to re-use Linux code. The 
> > compatibility layer should be very limited. Stefano any opinions?
> So when you mean linux code, you refer to a patch or importing the code 
> file from linux ?
Importing the code from Linux. And then a patch to adapt for Xen (it 
should be fairly small).
Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel