Re: [Xen-devel] [PATCH V2] tests/xen-access: disable CR4 write events on application exit

[Tamas K Lengyel <tamas@xxxxxxxxxxxxx>]

On Thu, Feb 1, 2018 at 12:31 AM, Razvan Cojocaru
<rcojocaru@xxxxxxxxxxxxxxx> wrote:
> On 01/29/2018 11:48 PM, Razvan Cojocaru wrote:
>> On exit, xen-access did not unsubscribe from CR4 write vm_events,
>> potentially leaving the guest stuck.
>>
>> Signed-off-by: Razvan Cojocaru <rcojocaru@xxxxxxxxxxxxxxx>

Acked-by: Tamas K Lengyel <tamas@xxxxxxxxxxxxx>

>>
>> ---
>> Changes since V1:
>>  - Made all the ignored parameters of xc_monitor_write_ctrlreg() zeroes.
>> ---
>>  tools/tests/xen-access/xen-access.c | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/tools/tests/xen-access/xen-access.c 
>> b/tools/tests/xen-access/xen-access.c
>> index 9d960e2109..a081168dea 100644
>> --- a/tools/tests/xen-access/xen-access.c
>> +++ b/tools/tests/xen-access/xen-access.c
>> @@ -654,6 +654,8 @@ int main(int argc, char *argv[])
>>                  rc = xc_monitor_cpuid(xch, domain_id, 0);
>>              if ( desc_access )
>>                  rc = xc_monitor_descriptor_access(xch, domain_id, 0);
>> +            if ( write_ctrlreg_cr4 )
>> +                rc = xc_monitor_write_ctrlreg(xch, domain_id, 
>> VM_EVENT_X86_CR4, 0, 0, 0, 0);
>>
>>              if ( privcall )
>>                  rc = xc_monitor_privileged_call(xch, domain_id, 0);
>>
>
> Tamas, could we get an ack (or otherwise) on this? This is probably
> small and out-of-the-way enough to make it in with the proper acks even
> with all the Spectre / Meltdown activity.
>
>
> Thanks,
> Razvan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel