Re: [Xen-devel] [PATCH v3 11/25] x86emul: place test blobs in executable section

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 02/02/18 15:27, Jan Beulich wrote:
>>>> On 02.02.18 at 14:03, <andrew.cooper3@xxxxxxxxxx> wrote:
>> On 07/12/17 14:06, Jan Beulich wrote:
>>> This allows the section contents to be disassembled without going
>>> through any extra hoops, simplifying the analysis of problems in test
>>> and/or emulation code.
>>>
>>> The blobs being emitted as (r/o) data means we need to accept an
>>> assembler warning here (about the differing section attributes).
>>>
>>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
>> What about just giving up their constness?  This is a test program after
>> all.
> Then the conflict would be in two attributes (writable and
> executable) rather than just one. The issue is that we emit them
> as data, but want them to be in an executable section. If anything
> we'd have to re-do how they're emitted (e.g. by using asm()), but
> that seems overkill to me.

Ok.  Instead, how about having a second .test.const? wouldn't that
resolve the warnings, but still leave the instructions in an executable
section?

Either way, this is just a developer utility, so Acked-by: Andrew Cooper
<andrew.cooper3@xxxxxxxxxx>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel