Re: [Xen-devel] [PATCH] vmx/altp2m: Use domain_crash_sync() when failing to find the current EPTP

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 05/02/18 11:21, Andrew Cooper wrote:
> When failing to locate the guests EPTP in the altp2m EPTP list, use
> domain_crash_sync() rather than domain_crash().  The latter returns and will
> hit the subsequent BUG().
>
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> ---
> CC: Jan Beulich <JBeulich@xxxxxxxx>
> CC: Jun Nakajima <jun.nakajima@xxxxxxxxx>
> CC: Kevin Tian <kevin.tian@xxxxxxxxx>
>
> N.B. Depends on "xen: Improvements to domain_crash_sync()"

In light of the changes in approach for domain_crash_sync(), this issue
will have to be fixed somehow else.

~Andrew

> ---
>  xen/arch/x86/hvm/vmx/vmx.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/xen/arch/x86/hvm/vmx/vmx.c b/xen/arch/x86/hvm/vmx/vmx.c
> index 3dc6a6d..f9438d7 100644
> --- a/xen/arch/x86/hvm/vmx/vmx.c
> +++ b/xen/arch/x86/hvm/vmx/vmx.c
> @@ -3583,10 +3583,7 @@ void vmx_vmexit_handler(struct cpu_user_regs *regs)
>  
>              if ( (idx = p2m_find_altp2m_by_eptp(v->domain, eptp)) ==
>                   INVALID_ALTP2M )
> -            {
> -                gdprintk(XENLOG_ERR, "EPTP not found in alternate p2m 
> list\n");
> -                domain_crash(v->domain);
> -            }
> +                domain_crash_sync("EPTP not found in alternate p2m list\n");
>          }
>  
>          if ( idx != vcpu_altp2m(v).p2midx )


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel