Re: [Xen-devel] [PATCH] x86/NMI: invert condition in nmi_show_execution_state()

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 06/02/18 10:41, Jan Beulich wrote:
> We want to decode the symbol when _not_ in guest mode.
>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>

Nice.  Figuring out why this wasn't working was on my todo list.

Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

>
> --- a/xen/arch/x86/traps.c
> +++ b/xen/arch/x86/traps.c
> @@ -632,7 +632,7 @@ static int nmi_show_execution_state(cons
>          show_execution_state(regs);
>      else
>          printk(XENLOG_ERR "CPU%d @ %04x:%08lx (%pS)\n", cpu, regs->cs,
> -               regs->rip, guest_mode(regs) ? _p(regs->rip) : NULL);
> +               regs->rip, guest_mode(regs) ? NULL : _p(regs->rip));
>      cpumask_clear_cpu(cpu, &show_state_mask);
>  
>      return 1;
>
>
>


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel