Re: [Xen-devel] [PATCH v4 3/7] libxl: introduce a new structure to represent static shared memory regions

[Julien Grall <julien.grall@xxxxxxx>]

Hi,

On 01/30/2018 05:50 PM, Zhongze Liu wrote:
> Add a new structure to the IDL familiy to represent static shared memory regions
s/familiy/family/

> as proposed in the proposal "Allow setting up shared memory areas between VMs
> from xl config file" (see [1]).
>
> And deleted some trailing white spaces.
>
> [1] https://lists.xen.org/archives/html/xen-devel/2017-08/msg03242.html
>
> Signed-off-by: Zhongze Liu <blackskygg@xxxxxxxxx>
> Reviewed-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>
> Acked-by: Wei Liu <wei.liu2@xxxxxxxxxx>
>
> Cc: Wei Liu <wei.liu2@xxxxxxxxxx>
> Cc: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>
> Cc: Julien Grall <julien.grall@xxxxxxx>
> Cc: xen-devel@xxxxxxxxxxxxx
> ---
>   tools/libxl/libxl.h         |  4 ++++
>   tools/libxl/libxl_types.idl | 32 ++++++++++++++++++++++++++++++--
>   2 files changed, 34 insertions(+), 2 deletions(-)
>
> diff --git a/tools/libxl/libxl.h b/tools/libxl/libxl.h
> index eca0ea2c50..372ad3cd32 100644
> --- a/tools/libxl/libxl.h
> +++ b/tools/libxl/libxl.h
> @@ -2365,6 +2365,10 @@ int libxl_fd_set_nonblock(libxl_ctx *ctx, int fd, int 
> nonblock);
>   int libxl_qemu_monitor_command(libxl_ctx *ctx, uint32_t domid,
>                                  const char *command_line, char **output);
>   
> +/* Constants for libxl_static_shm */
> +#define LIBXL_SSHM_RANGE_UNKNOWN UINT64_MAX
> +#define LIBXL_SSHM_ID_MAXLEN    128
> +
You need to add LIBXL_HAVE_* in libxl.h to tell shared memory regions 
are available. I wasn't able to find anything within this series.
>   #include <libxl_event.h>
>   
>   #endif /* LIBXL_H */
> diff --git a/tools/libxl/libxl_types.idl b/tools/libxl/libxl_types.idl
> index 35038120ca..4e9accf168 100644
> --- a/tools/libxl/libxl_types.idl
> +++ b/tools/libxl/libxl_types.idl
> @@ -559,10 +559,10 @@ libxl_domain_build_info = Struct("domain_build_info",[
>                                          ("keymap",           string),
>                                          ("sdl",              libxl_sdl_info),
>                                          ("spice",            libxl_spice_info),
> -
> +
>                                          ("gfx_passthru",     libxl_defbool),
>                                          ("gfx_passthru_kind", 
> libxl_gfx_passthru_kind),
> -
> +
>                                          ("serial",           string),
>                                          ("boot",             string),
>                                          ("usb",              libxl_defbool),
> @@ -816,6 +816,33 @@ libxl_device_vdispl = Struct("device_vdispl", [
>       ("connectors", Array(libxl_connector_param, "num_connectors"))
>       ])
>   
> +libxl_sshm_cachepolicy = Enumeration("sshm_cachepolicy", [
> +    (-1, "UNKNOWN"),
> +    (0,  "ARM_NORMAL"),  # ARM policies should be < 32
> +    (32,  "X86_NORMAL"), # X86 policies should be >= 32
> +    ], init_val = "LIBXL_SSHM_CHCHE_POLICY_UNKNOWN")
> +
> +libxl_sshm_prot = Enumeration("sshm_prot", [
> +    (-1, "UNKNOWN"),
> +    (3,  "RW"),
> +    ], init_val = "LIBXL_SSHM_PROT_UNKNOWN")
> +
> +libxl_sshm_role = Enumeration("sshm_role", [
> +    (-1, "UNKNOWN"),
> +    (0,  "MASTER"),
> +    (1,  "SLAVE"),
> +    ], init_val = "LIBXL_SSHM_ROLE_UNKNOWN")
> +
> +libxl_static_shm = Struct("static_shm", [
> +    ("id", string),
> +    ("offset", uint64, {'init_val': 'LIBXL_SSHM_RANGE_UNKNOWN'}),
> +    ("begin", uint64, {'init_val': 'LIBXL_SSHM_RANGE_UNKNOWN'}),
> +    ("end", uint64, {'init_val': 'LIBXL_SSHM_RANGE_UNKNOWN'}),
We might want to store the size rather than the end. This would allow us 
to cover region up to the address 2^64-1.
Also, this would make clearer whether end is included in the region or not.

> +    ("prot", libxl_sshm_prot, {'init_val': 'LIBXL_SSHM_PROT_UNKNOWN'}),
> +    ("cache_policy", libxl_sshm_cachepolicy, {'init_val': 
> 'LIBXL_SSHM_CACHEPOLICY_UNKNOWN'}),
> +    ("role", libxl_sshm_role, {'init_val': 'LIBXL_SSHM_ROLE_UNKNOWN'}),
> +])
> +
>   libxl_domain_config = Struct("domain_config", [
>       ("c_info", libxl_domain_create_info),
>       ("b_info", libxl_domain_build_info),
> @@ -835,6 +862,7 @@ libxl_domain_config = Struct("domain_config", [
>       ("channels", Array(libxl_device_channel, "num_channels")),
>       ("usbctrls", Array(libxl_device_usbctrl, "num_usbctrls")),
>       ("usbdevs", Array(libxl_device_usbdev, "num_usbdevs")),
> +    ("sshms", Array(libxl_static_shm, "num_sshms")),
>   
>       ("on_poweroff", libxl_action_on_shutdown),
>       ("on_reboot", libxl_action_on_shutdown),
Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel