Re: [Xen-devel] [PATCH v1 3/6] libxl: add backend type and id to vkb

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Tue, Feb 06, 2018 at 06:45:15PM +0200, Oleksandr Grytsov wrote:
> > > +static int libxl__set_xenstore_vkb(libxl__gc *gc, uint32_t domid,
> > > +                                   libxl_device_vkb *vkb,
> > > +                                   flexarray_t *back, flexarray_t
> > *front,
> > > +                                   flexarray_t *ro_front)
> > > +{
> > > +    if (vkb->id) {
> > > +        flexarray_append_pair(front, "id", vkb->id);
> > > +    }
> > > +
> >
> > Ditto.
> >
> > And, isn't 0 a valid device id?
> >
> >
> id here is char *. I put it to xenstore only if it is defined. It shall be
> defined for linux backend
> in case of multiple instances of kbd device are defined. The backend
> distinguishes them
> by id.

Oh I was a fool -- I misread that as dev_id which had numeric value.

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel