Re: [Xen-devel] [PATCH 2/4] firmware/shim: better filtering of dependency files during Xen tree setup

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 07.02.18 at 17:05, <roger.pau@xxxxxxxxxx> wrote:
> On Wed, Feb 07, 2018 at 08:07:40AM -0700, Jan Beulich wrote:
>> I have no idea what *.d1 is supposed to refer to - we only have .*.d
>> and .*.d2 files (note also the leading dot).
>> 
>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
>> 
>> --- a/tools/firmware/xen-dir/Makefile
>> +++ b/tools/firmware/xen-dir/Makefile
>> @@ -26,7 +26,7 @@ linkfarm.stamp: $(DEP_DIRS) $(DEP_FILES)
>>      $(foreach d, $(LINK_DIRS), \
>>              (cd $(XEN_ROOT); \
>>               find $(d) ! -type l -type f \
>> -             $(addprefix ! -path , '*.[oda1]' '*.d[12]')) \
>> +             $(addprefix ! -path , '*.[oa1]' '.*.d' '.*.d2')) \
> 
> Don't you want -name here instead of -path?
> 
> AFAICT using '.*.d' is not going to work with path, because that's the
> full path, not the name of the file. This used to work before because
> the patterns started with '*'.

Oh, good point. Once again I have no idea why -path was used in
the first place.

> Also I cannot find any .a or .1 files, but maybe that's just because
> of my build system (I don't build EFI).

The .1 part goes away in patch 3. I suppose .a is just to cover
archives even if we don't use any right now.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel