Re: [Xen-devel] [PATCH 2/3] libxl: Improve logging in libxl__build_dom()

[Roger Pau Monné <roger.pau@xxxxxxxxxx>]

On Thu, Feb 08, 2018 at 10:49:09PM +0100, Simon Gaiser wrote:
> xc_dom_parse_image() does not set errno (at least in many code paths).
> So LOGE() is not useful.

IIRC the expectation is that libxc functions will return -1 on failure
and set errno. This is however far from true, so:

> Signed-off-by: Simon Gaiser <simon@xxxxxxxxxxxxxxxxxxxxxx>

Reviewed-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>

Thanks.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel