Re: [Xen-devel] [PATCH 3/3] libxc: xc_dom_parse_elf_kernel: Return error for invalid kernel images

[Roger Pau Monné <roger.pau@xxxxxxxxxx>]

On Thu, Feb 08, 2018 at 10:49:10PM +0100, Simon Gaiser wrote:
> Commit 96edb111dd ("libxc: panic when trying to create a PVH guest
> without kernel support") already improved the handling of non PVH
> capable kernels. But xc_dom_parse_elf_kernel() still returned success on
> invalid elf images and the domain build only failed later. Now the build
> process will fail immediately on detecting the error.
> 
> Signed-off-by: Simon Gaiser <simon@xxxxxxxxxxxxxxxxxxxxxx>

LGTM:

Reviewed-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>

I'm not sure about the point of returning "xen-3.0-unknown" in
xc_dom_guest_type in the first place, but maybe I'm missing something.
When parsing the kernel there's no falling back to other loaders.

Thanks, Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel