Re: [Xen-devel] [PATCH v2 2/4] hvm/svm: Enable Breakpoint events

[Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>]

On 02/08/2018 10:25 AM, Alexandru Isaila wrote:

> +
> +           rc = hvm_monitor_debug(regs->rip,
> +                                  HVM_MONITOR_SOFTWARE_BREAKPOINT,
> +                                  X86_EVENTTYPE_SW_EXCEPTION,
> +                                  inst_len);
> +           if ( rc < 0 )
> +               goto unexpected_exit_type;
> +           if ( !rc )
> +               svm_propagate_intr(v, inst_len);

There is a comment in vmx_vmexit_handler() where this call is made a 
couple of times that explains hvm_moonitor_debug()'s return values.
Can you move that comment to hvm_monitor_debug() definition so people 
can look there to understand how to deal with return values instead of 
searching for call sites?
-boris

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel