Re: [Xen-devel] [PATCH 1/7] Port WARN_ON_ONCE() from Linux

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Thu, Feb 08, 2018 at 08:10:49PM -0700, Sameer Goel wrote:
>  
> +#define WARN_ON_ONCE(p)                             \
> +({                                                  \
> +    static bool __section(".data.unlikely") __warned; \
> +    int __ret_warn_once = !!(p);                    \
> +                                                    \
> +    if ( unlikely(__ret_warn_once && !__warned) )     \
> +    {                                               \
> +        __warned = true;                            \

Please don't mix bool and int type.

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel