Re: [Xen-devel] [PATCH v3 2/3] x86/svm: add EFER SVME support for VGIF/VLOAD

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 08.02.18 at 18:01, <brian.woods@xxxxxxx> wrote:
> --- a/xen/arch/x86/hvm/svm/svm.c
> +++ b/xen/arch/x86/hvm/svm/svm.c
> @@ -611,6 +611,12 @@ static void svm_update_guest_efer(struct vcpu *v)
>      if ( lma )
>          new_efer |= EFER_LME;
>      vmcb_set_efer(vmcb, new_efer);
> +
> +    if ( !nestedhvm_enabled(v->domain) )
> +        ASSERT(!(v->arch.hvm_vcpu.guest_efer & EFER_SVME));
> +
> +    if ( nestedhvm_enabled(v->domain) )
> +        svm_nested_features_on_efer_update(v);
>  }

Why not

    if ( nestedhvm_enabled(v->domain) )
        svm_nested_features_on_efer_update(v);
    else
        ASSERT(!(v->arch.hvm_vcpu.guest_efer & EFER_SVME));

?

Jan




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel