Re: [Xen-devel] [PATCH v2 13/16] Save/Restore Support: Add suspend/restore support for Grant Tables.

[Juergen Gross <jgross@xxxxxxxx>]

On 14/02/18 03:27, Bruno Alvisio wrote:
> Signed-off-by: Bruno Alvisio <bruno.alvisio@xxxxxxxxx>
> ---
> Changed since v1:
>     - Moved suspend/resume _gnttab to arch specific files
> ---
>  arch/x86/mm.c    | 34 ++++++++++++++++++++++++++++++++++
>  gnttab.c         | 10 ++++++++++
>  include/gnttab.h |  4 ++++
>  kernel.c         |  4 ++++
>  4 files changed, 52 insertions(+)
> 
> diff --git a/arch/x86/mm.c b/arch/x86/mm.c
> index 1b163ac..2597c5b 100644
> --- a/arch/x86/mm.c
> +++ b/arch/x86/mm.c
> @@ -917,6 +917,40 @@ grant_entry_v1_t *arch_init_gnttab(int nr_grant_frames)
>      return map_frames(frames, nr_grant_frames);
>  }
>  
> +void arch_suspend_gnttab(grant_entry_v1_t *gnttab_table, int nr_grant_frames)
> +{
> +#ifdef CONFIG_PARAVIRT
> +    int i;
> +
> +    for (i = 0; i < nr_grant_frames; i++) {
> +        HYPERVISOR_update_va_mapping((unsigned long)(((char *)gnttab_table) 
> + PAGE_SIZE*i),
> +                (pte_t){0x0<<PAGE_SHIFT}, UVMF_INVLPG);

Coding style (blanks around operators, once again below).


Other than that:

Reviewed-by: Juergen Gross <jgross@xxxxxxxx>


Juergen

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel