Re: [Xen-devel] [PATCH v4 0/4] hvm/svm: Enable vm events for SVM

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 15/02/18 10:22, Alexandru Isaila wrote:
> Hi all,
>
> This series provides a skeleton for enabling vm_events on SVM. For the
> first step, the MSR, CR, Breakpoint and GuestRequest have been tested
> and added to the capabilities list.

Ok - this series is looking much clearer now.  Thanks.

Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx> (although there is
one trivial style issue in patch 1 I can fix on commit).

You are still waiting for SVM acks on patches 1 and 3 by the looks of
things.

One thing I note however is that patch 2 and 3 both turn on intercepts
and have no way of turning them back off.  This appears to be consistent
with the Intel side of things, but it is suboptimal for the guest when
an introspection agent detaches.

For the CPUID/MSR policy side of things, Jan has talked me in to
changing how cpuid_policy_updated() works, and implementing it as a
recalculation of the intercepts on the return-to-guest path.  It occurs
to me that this usefully extends to changes requested by the
introspection agent.

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel