Re: [Xen-devel] [PATCH V4] x86/hvm: fix domain crash when CR3 has the noflush bit set

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 15.02.18 at 17:57, <andrew.cooper3@xxxxxxxxxx> wrote:
> On 15/02/18 16:50, Jan Beulich wrote:
>>> --- a/xen/include/asm-x86/x86-defns.h
>>> +++ b/xen/include/asm-x86/x86-defns.h
>>> @@ -43,6 +43,11 @@
>>>  #define X86_CR0_PG              0x80000000 /* Paging                   
>>> (RW) 
> 
>>> */
>>>  
>>>  /*
>>> + * Intel CPU flags in CR3
>>> + */
>>> +#define X86_CR3_NOFLUSH    0x8000000000000000
>> Please add the ULL suffix, so the insn emulator could eventually
>> use this without breaking the 32-bit test harness build.
> 
> _AC(... , ULL) please.  If Xen does start using PCID, then we will need
> this usable in asm.

Oh, of course - any constants in headers usable by assembly files
should have suffixes, if any, attached via _AC().

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel