Re: [Xen-devel] [PATCH v1 2/2] hvm/svm: Implement CPUID events

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 19.02.18 at 16:25, <tamas@xxxxxxxxxxxxx> wrote:
> On Mon, Feb 19, 2018 at 6:07 AM, Alexandru Isaila <aisaila@xxxxxxxxxxxxxxx> 
> wrote:
>> @@ -1822,7 +1823,12 @@ static void svm_vmexit_do_cpuid(struct cpu_user_regs 
>> *regs)
>>      regs->rcx = res.c;
>>      regs->rdx = res.d;
>>
>> -    __update_guest_eip(regs, inst_len);
>> +    rc = hvm_monitor_cpuid(inst_len, regs->eax, regs->ecx);
>> +
>> +    if ( !rc )
> 
> Missing the rc < 0 case handling.
> 
>> +    {
>> +        __update_guest_eip(regs, inst_len);
>> +    }

Also please omit the braces in cases like this one.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel