Re: [Xen-devel] [PATCH v4 4/4] build/clang: add a check whether the assembler supports .skip with labels

[Roger Pau Monné <roger.pau@xxxxxxxxxx>]

On Mon, Feb 19, 2018 at 09:10:42AM -0700, Jan Beulich wrote:
> >>> On 19.02.18 at 15:16, <roger.pau@xxxxxxxxxx> wrote:
> > --- a/xen/Rules.mk
> > +++ b/xen/Rules.mk
> > @@ -72,7 +72,11 @@ AFLAGS-y                += -D__ASSEMBLY__
> >  
> >  # Older clang's built-in assembler doesn't understand .skip with labels:
> >  # https://bugs.llvm.org/show_bug.cgi?id=27369 
> > -AFLAGS-$(clang)         += -no-integrated-as
> > +ifeq ($(clang),y)
> > +ifeq ($(call as-insn,$(CC) $(AFLAGS),".L0:\n.L1:\n.skip (.L1 - 
> > .L0)",y,n),n)
> 
> Hmm, here you use AFLAGS, so why not as-insn-check?

Because as-insn-check only lets you add to a variable on the success
case (ie: when as-insn returns 'y'), and here I need to do the
opposite.

Thanks, Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel