Re: [Xen-devel] [PATCH v4 3/4] x86: fix indirect thunk usage of CONFIG_INDIRECT_THUNK

[Roger Pau Monné <roger.pau@xxxxxxxxxx>]

On Tue, Feb 20, 2018 at 02:15:24AM -0700, Jan Beulich wrote:
> >>> On 19.02.18 at 15:16, <roger.pau@xxxxxxxxxx> wrote:
> > --- a/xen/include/asm-x86/indirect_thunk_asm.h
> > +++ b/xen/include/asm-x86/indirect_thunk_asm.h
> > @@ -3,6 +3,10 @@
> >   * usual #ifdef'ary to turn into comments.
> >   */
> >  
> > +.ifndef CONFIG_INDIRECT_THUNK
> > +    .equ CONFIG_INDIRECT_THUNK, 0
> > +.endif
> 
> I have to withdraw my R-b: This fails to build (I'm getting an error
> on the .ifndef above for more than one assembler source). I assume
> that's because with indirect thunks enabled the constant gets
> replaced by literal 1 by the C preprocessor.

Right, I've just installed gcc7-devel and I'm seeing the same. Thanks
for noticing. Let me try to solve this in another way...

Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel