Re: [Xen-devel] [PATCH v2] build: remove shim related targets

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 20/02/18 14:37, Roger Pau Monne wrote:
> diff --git a/tools/firmware/xen-dir/Makefile b/tools/firmware/xen-dir/Makefile
> index 7fd36a0e15..01a2850194 100644
> --- a/tools/firmware/xen-dir/Makefile
> +++ b/tools/firmware/xen-dir/Makefile
> @@ -48,13 +48,14 @@ shim-%config: $(D) FORCE
>               KCONFIG_CONFIG=$(CURDIR)/shim.config
>  
>  xen-shim: $(D) shim-olddefconfig
> -     $(MAKE) -C $(D)/xen install-shim \
> +     $(MAKE) -C $(D)/xen build \
>               XEN_CONFIG_EXPERT=y \
> -             KCONFIG_CONFIG=$(CURDIR)/shim.config \
> -             DESTDIR=$(CURDIR)
> +             KCONFIG_CONFIG=$(CURDIR)/shim.config
> +     ln -sf $(D)/xen/xen xen-shim
> +     ln -sf $(D)/xen/xen-syms xen-shim-syms

This might be fine for developer builds, but it will break RPM (and
probably DEB) packages.

They are separate files, and need copying into place, to avoid
interacting with later rebuilds of Xen.

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel