Re: [Xen-devel] [PATCH] domctl: revert double increment of domctl version

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 21/02/18 17:38, Wei Liu wrote:
> On Wed, Feb 21, 2018 at 06:34:22PM +0100, Olaf Hering wrote:
>> Xen 4.10 has XEN_DOMCTL_INTERFACE_VERSION 0xe, staging should be fine
>> with 0xf until the next release is prepared.
>>
>> Signed-off-by: Olaf Hering <olaf@xxxxxxxxx>
>> ---
>>  xen/include/public/domctl.h | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/xen/include/public/domctl.h b/xen/include/public/domctl.h
>> index ec7a860afc..501c44230b 100644
>> --- a/xen/include/public/domctl.h
>> +++ b/xen/include/public/domctl.h
>> @@ -38,7 +38,7 @@
>>  #include "hvm/save.h"
>>  #include "memory.h"
>>  
>> -#define XEN_DOMCTL_INTERFACE_VERSION 0x00000010
>> +#define XEN_DOMCTL_INTERFACE_VERSION 0x0000000f
>>  
> The reason we bumped the number twice is because we want a dedicated
> number to denote the recent security fix.

The double bump is there because Jan insisted upon it, so there is a
number to burn if we decide to backport part of PV-in-PVH to Xen 4.10. 
It is currently unused.

I continue to think that this is a mistake (which is backed up by
everyone else being confused about what is going on), and demonstrates
the ineffectiveness of the *_INTERFACE_VERSIONS in general.

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel