Re: [Xen-devel] [PATCH] xtf: fix cdefs.h conflict with __section

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 22/02/18 12:24, Jan Beulich wrote:
>>>> On 22.02.18 at 13:03, <roger.pau@xxxxxxxxxx> wrote:
>> On FreeBSD the build fails with:
>>
>> /root/src/xtf/include/xtf/compiler.h:13:9: error: '__section' macro 
>> redefined
>>       [-Werror,-Wmacro-redefined]
>> #define __section(s)          __attribute__((__section__(s)))
>>         ^
>> /usr/include/sys/cdefs.h:229:9: note: previous definition is here
>> #define __section(x)    __attribute__((__section__(x)))
>>         ^
>> 1 error generated.
>>
>> Only define __section if it's undefined in order to prevent conflicts.
> But the actual bug is that /usr/include/sys/cdefs.h is (magically?)
> being included. Just like the hypervisor build, the xtf one shouldn't
> pull in _any_ external headers.

XTF uses the following freestanding headers only.

#include <stdint.h>
#include <stdbool.h>
#include <stdarg.h>
#include <stddef.h>
#include <inttypes.h>
#include <limits.h>

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel