Re: [Xen-devel] [PATCH 5/5] xen/libxc: suppress direct access to Credit1's migration delay

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Thu, Feb 22, 2018 at 05:55:32PM +0100, Dario Faggioli wrote:
> Removes special purpose access to Credit1 vCPU
> migration delay parameter.
> 
> This fixes a build breakage, occuring when Xen
> is configured with SCHED_CREDIT=n.
> 
> Signed-off-by: Dario Faggioli <dfaggioli@xxxxxxxx>
> ---
> Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> Wei Liu <wei.liu2@xxxxxxxxxx>
> Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> George Dunlap <George.Dunlap@xxxxxxxxxxxxx>
> Jan Beulich <jbeulich@xxxxxxxx>
> Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
> Stefano Stabellini <sstabellini@xxxxxxxxxx>
> Tim Deegan <tim@xxxxxxx>
> George Dunlap <george.dunlap@xxxxxxxxxxxxx>

Forgot to prepend "Cc: ". :-)

> ---
>  tools/libxc/include/xenctrl.h |    2 --
>  tools/libxc/xc_pm.c           |   30 ------------------------------
>  xen/common/sched_credit.c     |   10 ----------
>  xen/drivers/acpi/pmstat.c     |   12 ------------
>  xen/include/public/sysctl.h   |    2 --
>  xen/include/xen/sched.h       |    3 ---
>  6 files changed, 59 deletions(-)
> 
> diff --git a/tools/libxc/include/xenctrl.h b/tools/libxc/include/xenctrl.h
> index 543abfcb34..058e832c47 100644
> --- a/tools/libxc/include/xenctrl.h
> +++ b/tools/libxc/include/xenctrl.h
> @@ -1920,8 +1920,6 @@ int xc_set_cpufreq_para(xc_interface *xch, int cpuid,
>  int xc_get_cpufreq_avgfreq(xc_interface *xch, int cpuid, int *avg_freq);
>  
>  int xc_set_sched_opt_smt(xc_interface *xch, uint32_t value);
> -int xc_set_vcpu_migration_delay(xc_interface *xch, uint32_t value);
> -int xc_get_vcpu_migration_delay(xc_interface *xch, uint32_t *value);

Isn't xenpm using these two functions? See tools/misc/pm.c.

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel