Re: [Xen-devel] [PATCH V5] x86/hvm: fix domain crash when CR3 has the noflush bit set

["Tian, Kevin" <kevin.tian@xxxxxxxxx>]

> From: Razvan Cojocaru [mailto:rcojocaru@xxxxxxxxxxxxxxx]
> Sent: Friday, February 23, 2018 3:32 PM
> 
> On 02/23/2018 09:29 AM, Razvan Cojocaru wrote:
> > Lacking PCID support in the emulation layer creates two different way of
> > handling the NOFLUSH being set: one is in hardware, and this happens for
> > everything except the introspection case, and one in the emulation layer
> > (this happens when an introspection agent asks Xen to emulate an
> > instruction when it replies to an EPT fault vm_event).
> 
> Sorry, not when the introspection agent asks Xen to emulate an
> instruction when it replies to an EPT fault vm_event, but when the
> introspection agent wants to be able to veto a CR3 write - i.e. when the
> introspection agent subscribes to CR3 write events.
> 

yes, that's what I wondered when reading your 1st reply. 

Now I understood the background and the patch overall looks
good to me. 

Reviewed-by: Kevin Tian <kevin.tian@xxxxxxxxx>
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel