Re: [Xen-devel] [PATCH v2] x86/mm: Suppresses vm_events caused by page-walks

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 23.02.18 at 18:46, <wei.liu2@xxxxxxxxxx> wrote:
> On Mon, Jan 08, 2018 at 02:49:44PM +0200, Alexandru Isaila wrote:
>> ---
>>  tools/libxc/include/xenctrl.h |  2 ++
>>  tools/libxc/xc_monitor.c      | 14 ++++++++++++++
> 
> These changes look sensible to me.
> 
>>  xen/arch/x86/mm/mem_access.c  | 27 +++++++++++++++++++++++++++
>>  xen/arch/x86/monitor.c        | 13 +++++++++++++
>>  xen/include/asm-x86/domain.h  |  6 ++++++
>>  xen/include/asm-x86/monitor.h |  3 ++-
>>  xen/include/public/domctl.h   |  2 ++
> 
> You might want to bump domctl version number it is has been done already
> in this release.

For one this sentence confuses me by its wording alone. And then
all the patch does is add a #define, which doesn't alter the
interface in an incompatible way (which is what the interface
version tries to express, even if - I agree with Andrew here -
limitations).

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel