Re: [Xen-devel] [PATCH v2] tools/xenstore: try to get minimum thread stack size for watch thread

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Mon, Feb 26, 2018 at 09:46:01AM +0000, Roger Pau Monné wrote:
> >  
> >             if (pthread_attr_init(&attr) != 0) {
> >                     mutex_unlock(&h->request_mutex);
> >                     return false;
> >             }
> > -           if (pthread_attr_setstacksize(&attr, READ_THREAD_STACKSIZE) != 
> > 0) {
> > +           if (!stack_size) {
> > +#ifdef USE_DLSYM
> > +                   getsz = dlsym(RTLD_DEFAULT, "__pthread_get_minstack");
> 
> dlsym is part of libc in FreeBSD, so it can be used but there's no ldl
> library (so passing -ldl to the linker is going to throw an error).
> 
> I guess it would be nice to have a configure test for this, but I'm
> not going to argue over it.

I don't think FreeBSD needs this particular workaround for glibc FWIW.

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel