Re: [Xen-devel] [PATCH] x86/PV: fix off-by-one in I/O bitmap limit check

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 26/02/18 10:50, Jan Beulich wrote:
>>>> On 26.02.18 at 11:44, <roger.pau@xxxxxxxxxx> wrote:
>> On Mon, Feb 26, 2018 at 12:38:11AM -0700, Jan Beulich wrote:
>>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
>> Reviewed-by: Roger Pau Monné <roger.apu@xxxxxxxxxx>
> Thanks.
>
>> I would however invert the check, my brain finds it easier to read
>> as:
>>
>> (port + bytes) <= v->arch.pv_vcpu.iobmp_limit
> My brain too, but I didn't want to make unrelated changes.

Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>.  I think this is
a sufficiently small and well-describe change that rearranging the
expression for clarity is fine.

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel