Re: [Xen-devel] [RFC XEN PATCH v4 33/41] tools/libacpi, hvmloader: detect QEMU fw_cfg interface

[Haozhong Zhang <haozhong.zhang@xxxxxxxxx>]

On 02/27/18 17:37 +0000, Anthony PERARD wrote:
> On Thu, Dec 07, 2017 at 06:10:22PM +0800, Haozhong Zhang wrote:
> > Add a function in libacpi to detect QEMU fw_cfg interface. Limit the
> > usage of fw_cfg interface to hvmloader now, so use stub functions for
> > others.
> 
> I think libacpi is not the right place for a driver. The fw_cfg driver
> would be better in hvmloader.

Yes, I can move it to hvmloader. My original thought was it might be
reused (by replacing those stub functions) when someone wants to add
vNVDIMM support to PVH domU and still use QEMU as the device model
for vNVDIMM.

> 
> As to copy the ACPI tables from fw_cfg to libacpi, maybe the passthrough
> tables (or an improvement of it) could be use. (It is already to to add
> extra tables from libxl (HVM_XS_ACPI_PT_ADDRESS).)
>

They are doing the same job (transferring guest ACPI from host to
guest) in two quite different ways, rather than two pieces of jobs not
completely overlap, so I think it's hard to let them collaborate with
each other. Do you have any idea in mind?

Thanks,
Haozhong

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel