Re: [Xen-devel] [PATCH v3] build: remove shim related targets

[Roger Pau Monné <roger.pau@xxxxxxxxxx>]

On Wed, Feb 28, 2018 at 04:02:53AM -0700, Jan Beulich wrote:
> >>> On 21.02.18 at 13:22, <roger.pau@xxxxxxxxxx> wrote:
> > --- a/tools/firmware/Makefile
> > +++ b/tools/firmware/Makefile
> > @@ -8,6 +8,7 @@ endif
> >  # hvmloader is a 32-bit protected mode binary.
> >  TARGET      := hvmloader/hvmloader
> >  INST_DIR := $(DESTDIR)$(XENFIRMWAREDIR)
> > +DEBG_DIR := $(DESTDIR)$(DEBUG_DIR)$(XENFIRMWAREDIR)
> 
> This is screwing up my build, and looking again I can't see how
> this can be right: Both $(XENFIRMWAREDIR) and $(DEBUG_DIR)
> are supposed to be ${prefix}-able, yet there clearly should not
> be an infix resulting from the construction of this path.

By being prefixable you mean that both XENFIRMWAREDIR and DEBUG_DIR
can be relative paths?

> In that context I wonder why DEBUG_DIR is set in
> {StdGNU,SunOS}.mk instead of having a template in
> Paths.mk.in.

Then you would have to run configure before installing the hypervisor,
because the install hypervisor target uses DEBUG_DIR.

Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel