Re: [Xen-devel] [PATCH v8 07/11] vpci/bars: add handlers to map the BARs

[Roger Pau Monné <roger.pau@xxxxxxxxxx>]

On Wed, Feb 28, 2018 at 04:34:01AM -0700, Jan Beulich wrote:
> >>> On 28.02.18 at 12:20, <roger.pau@xxxxxxxxxx> wrote:
> > I've been giving some thought to this, and I cannot find a good
> > solution. So far the less worse one would be:
> > 
> >     +--------------+  YES  +---------+
> >     |Is broken set?|------>|No action|
> >     +--------------+       +---------+
> >          |
> >          | NO
> >      |
> >     +----v----+   SUCCESS  +---------------------------------+
> >     |map/unmap+------------>Change decoding or ROM enable bit|
> >     +----+----+            +---------------------------------+
> >          |
> >          |FAILURE
> >          |
> > +--------v----------------+
> > |Clear memory decoding bit|
> > |Set broken               |
> > +-------------------------+
> > 
> > Let me know what you think of this.
> 
> Looks reasonable, maybe with "set broken" replaced by "set
> broken if Dom0, else remove device from domain". This at least
> partly depends on how recovery from "broken" would look like,
> i.e. whether that would be applicable (and safe) for a DomU as
> well.

I will add the "remove device from domain" for the DomU case and put
this as a comment somewhere. IMO it can always be improved in the
future with better recovery options.

Thanks, Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel