Re: [Xen-devel] [PATCH 6/6] x86/msr: Blacklist various MSRs which guests definitely shouldn't be using

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 26.02.18 at 18:35, <andrew.cooper3@xxxxxxxxxx> wrote:
> @@ -183,6 +187,15 @@ int guest_rdmsr(const struct vcpu *v, uint32_t msr, 
> uint64_t *val)
>          ret = guest_rdmsr_x2apic(v, msr, val);
>          goto out;
>  
> +    case 0xc80:
> +        /* Silicon Debug Inferface not advertised to guests. */
> +        goto gp_fault;
> +
> +    case 0xc81 ... 0xc8f: /* Misc RDT MSRs. */
> +    case 0xc90 ... 0xd8f: /* CAT Mask registers. */

At the very least where we already have #define-s you should use
those. Even better would be if you also introduced #define-s for
ones we don't handle anywhere yet, as Roger has also suggested.

Furthermore, what makes you imply the entire c81..c8f range is
RDT?

And then - even calling them RDT / CAT is questionable - the same
numbers have another use on the Xeon 7500 series as per the SDM.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel