Re: [Xen-devel] Crash with your meltdown patches

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 01.03.18 at 19:23, <jgross@xxxxxxxx> wrote:
> --- a/xen/arch/x86/smpboot.c
> +++ b/xen/arch/x86/smpboot.c
> @@ -747,10 +747,9 @@ static int clone_mapping(const void *ptr,root_pgentry_t 
> *rpt)
>      if ( l1e_get_flags(*pl1e) & _PAGE_PRESENT )
>      {
>          ASSERT(l1e_get_pfn(*pl1e) == pfn);
> -        ASSERT(l1e_get_flags(*pl1e) == flags);
> +        ASSERT((l1e_get_flags(*pl1e) & ~_PAGE_GLOBAL) == flags);
>      }
> -    else
> -        l1e_write(pl1e, l1e_from_pfn(pfn, flags));
> +    l1e_write(pl1e, l1e_from_pfn(pfn, flags));

I agree with the change to the ASSERT(), but why the dropping of
the "else"?

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel