Re: [Xen-devel] [PATCH v4 07/16] xen/x86: mm: Switch x86/mm.c to use typesafe for virt_to_mfn

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 21.02.18 at 15:02, <julien.grall@xxxxxxx> wrote:
> No functional change intended.
> 
> Signed-off Julien Grall <julien.grall@xxxxxxx>

Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
with one remark:

> @@ -5545,8 +5547,7 @@ static void __memguard_change_range(void *p, unsigned 
> long l, int guard)
>      if ( guard )
>          flags &= ~_PAGE_PRESENT;
>  
> -    map_pages_to_xen(
> -        _p, virt_to_maddr(p) >> PAGE_SHIFT, _l >> PAGE_SHIFT, flags);
> +    map_pages_to_xen(_p, mfn_x(virt_to_mfn(p)), _l >> PAGE_SHIFT, flags);

Would have been nice if this was switched to PFN_DOWN() instead
of the open coded shift right away.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel