Re: [Xen-devel] [PATCH v4 14/16] xen/grant: Switch common/grant_table.c to use typesafe MFN

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 02.03.18 at 16:59, <julien.grall@xxxxxxx> wrote:
> On 02/03/18 15:54, Jan Beulich wrote:
>>>>> On 21.02.18 at 15:02, <julien.grall@xxxxxxx> wrote:
>>> @@ -872,7 +879,7 @@ map_grant_ref(
>>>       struct grant_table *lgt, *rgt;
>>>       struct vcpu   *led;
>>>       grant_handle_t handle;
>>> -    unsigned long  frame = 0;
>>> +    mfn_t frame = _mfn(0);
>> 
>> If the initializer is needed at all, I think it should again become
>> INVALID_MFN. Same in a few other places.
> 
> I didn't switch to INVALID_MFN because I wasn't sure if some place in 
> the code where relying on 0. If you think it is fine, then I am more 
> thank happy to switch to INVALID_MFN.

Well, as said - it looks as if the initializer isn't needed at all, in
which case it's value really is a don't care.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel