Re: [Xen-devel] [PATCH v2 4/5] x86/pv: Drop {compat_, }create_bounce_frame() and use the C version instead

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 27.02.18 at 15:50, <andrew.cooper3@xxxxxxxxxx> wrote:
> -compat_create_bounce_frame:
> -        ASSERT_INTERRUPTS_ENABLED
> -        mov   %fs,%edi
> -        ASM_STAC
> -        testb $2,UREGS_cs+8(%rsp)
> -        jz    1f
> -        /* Push new frame at registered guest-OS stack base. */
> -        movl  VCPU_kernel_sp(%rbx),%esi
> -.Lft1:  mov   VCPU_kernel_ss(%rbx),%fs

Note how we did take into consideration the segment base here;
pv_create_bounce_frame() doesn't. Hence while the patch here
is
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
I'm afraid I have to withdraw the respective tag for the earlier one
(despite realizing that there are other places where we [wrongly]
assume stack segments to be flat).

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel