Re: [Xen-devel] [PATCH v1] pv_console: remove unnecessary #ifdefs

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 06.03.18 at 09:51, <sergey.dyasli@xxxxxxxxxx> wrote:
> The header for PV console contains empty function definitions in case of
> !CONFIG_XEN_GUEST specially to avoid #ifdefs in a code that uses them
> to make the code look cleaner.
> 
> Unfortunately, during the release of shim-comet, PV console functions
> were enclosed into unnecessary #ifdefs CONFIG_X86. Remove them.
> 
> Signed-off-by: Sergey Dyasli <sergey.dyasli@xxxxxxxxxx>

Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
with one remark:

> @@ -816,9 +814,9 @@ void __init console_init_preirq(void)
>              p++;
>          if ( !strncmp(p, "vga", 3) )
>              video_init();
> -#ifdef CONFIG_X86
>       else if ( !strncmp(p, "pv", 2) )

Would be nice to fix the indentation issue here at the same
time; can be done while committing of course.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel