Re: [Xen-devel] [PATCH v2] tools/xenstore: try to get minimum thread stack size for watch thread

[Juergen Gross <jgross@xxxxxxxx>]

On 06/03/18 12:24, Olaf Hering wrote:
> On Fri, Mar 02, Wei Liu wrote:
> 
>> But still, Juergen must have tested the change, so I wonder why it
>> doesn't work in your setup. What is your build environment? Gcc version?
> 
> Unclear what the difference is between building in clean chroot and locally.
> This change fixes it for me:
> 
> --- a/tools/Rules.mk
> +++ b/tools/Rules.mk
> @@ -148,6 +148,9 @@ SHLIB_libxenguest  = $(SHDEPS_libxenguest) 
> -Wl,-rpath-link=$(XEN_LIBXC)
>  CFLAGS_libxenstore = -I$(XEN_XENSTORE)/include $(CFLAGS_xeninclude)
>  SHDEPS_libxenstore = $(SHLIB_libxentoolcore)
>  LDLIBS_libxenstore = $(SHDEPS_libxenstore) 
> $(XEN_XENSTORE)/libxenstore$(libextension)
> +ifeq ($(CONFIG_Linux),y)
> +LDLIBS_libxenstore += -ldl
> +endif

So we need to add this to xenstore.pc, right?

>  SHLIB_libxenstore  = $(SHDEPS_libxenstore) -Wl,-rpath-link=$(XEN_XENSTORE)
>  
>  CFLAGS_libxenstat  = -I$(XEN_LIBXENSTAT)
> --- a/tools/xenstore/Makefile
> +++ b/tools/xenstore/Makefile
> @@ -103,6 +103,7 @@ xs.opic: CFLAGS += -DUSE_PTHREAD
>  ifeq ($(CONFIG_Linux),y)
>  xs.opic: CFLAGS += -DUSE_DLSYM
>  libxenstore.so.$(MAJOR).$(MINOR): LDFLAGS += -ldl
> +LDLIBS_xenstored += -ldl

Why is this needed? xenstored doesn't need libxenstore and (at least on
my system) doesn't try to load it. The "-ldl" addition should only be
needed for programs linked against libxenstore.


Juergen

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel