Re: [Xen-devel] [PATCH 16/57] ARM: GICv3: rename HYP interface definitions to use ICH_ prefix

[Julien Grall <julien.grall@xxxxxxx>]

Hi Andre,

On 05/03/18 16:03, Andre Przywara wrote:
> On a GICv3 in non-compat mode the hypervisor interface is always
> accessed via system registers. Those register names have a "ICH_" prefix
> in the manual, to differentiate them from the MMIO registers. Also those
> registers are mostly 64-bit (compared to the 32-bit GICv2 registers) and
> use different bit assignments.
> To make this obvious and to avoid clashes with double definitions using
> the same names for actually different bits, lets change all GICv3
> hypervisor interface registers to use the "ICH_" prefix from the manual.
> This renames the definitions in gic_v3_defs.h and their usage in gic-v3.c
> and is needed to allow co-existence of the GICv2 and GICv3 definitions
> in the same file.
>
> Signed-off-by: Andre Przywara <andre.przywara@xxxxxxxxxx>
I guess this was compiled test in standalone? On that a basis:

Acked-by: Julien Grall <julien.grall@xxxxxxx>

Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel