[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [OSSTEST PATCH v2 17/19] Skip bootloader installation for arm32 in Stretch
Wei Liu writes ("[OSSTEST PATCH v2 17/19] Skip bootloader installation for arm32 in Stretch"): > Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx> Acked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx> But some minor style questions: > diff --git a/Osstest/Debian.pm b/Osstest/Debian.pm > index 2c3bcf4..b2d5007 100644 > --- a/Osstest/Debian.pm > +++ b/Osstest/Debian.pm > @@ -1027,6 +1027,11 @@ END > $preseed_file.= (<<END); > d-i nobootloader/confirmation_common boolean true > END > + # Stretch has a different method to skip bootloader installation > + $preseed_file.= (<<END); > +d-i grub-installer/skip boolean true > +d-i lilo-installer/skip boolean true Why not fold this into the same here document ? I would put the comments in the preseed file, for both versions, eg: +# jessie and earlier: d-i nobootloader/confirmation_common boolean true +# stretch and later: +d-i grub-installer/skip boolean true +d-i lilo-installer/skip boolean true Ian. _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxxx https://lists.xenproject.org/mailman/listinfo/xen-devel
|
![]() |
Lists.xenproject.org is hosted with RackSpace, monitoring our |