|
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [Xen-devel] [xen-unstable-smoke bisection] complete build-arm64-xsm
branch xen-unstable-smoke xenbranch xen-unstable-smoke job build-arm64-xsm testid xen-build Tree: qemuu git://xenbits.xen.org/qemu-xen.git Tree: xen git://xenbits.xen.org/xen.git *** Found and reproduced problem changeset *** Bug is in tree: xen git://xenbits.xen.org/xen.git Bug introduced: 340edc3902c1757a0e1f4391930366fb25a05df3 Bug not present: 27254e45b102e933ec9b4fb630b384b708301095 Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/120335/ commit 340edc3902c1757a0e1f4391930366fb25a05df3 Author: Andrew Cooper <andrew.cooper3@xxxxxxxxxx> Date: Tue Feb 27 16:48:19 2018 +0000 xen/sched: Improvements to the {alloc,free}_domdata() interfaces The main purpose of this change is for the subsequent cleanup it enables, but it stands on its own merits. In principle, these hooks are optional, but the SCHED_OP() default aliases a memory allocation failure, which causes arinc653 to play the dangerous game of passing its priv pointer back, and remembering not to actually free it. Redefine alloc_domdata to use ERR_PTR() for errors, NULL for nothing, and non-NULL for a real allocation, which allows the hook to become properly optional. Redefine free_domdata to be idempotent. For arinc653, this means the dummy hooks can be dropped entirely. For the other schedulers, this means returning ERR_PTR(-ENOMEM) instead of NULL for memory allocation failures, and modifying the free hooks to cope with a NULL pointer. While making the alterations, drop some spurious casts to void *. Introduce and use proper wrappers for sched_{alloc,free}_domdata(). These are strictly better than SCHED_OP(), as the source code is visible to grep/cscope/tags, the generated code is better, and there can be proper per-hook defaults and checks. Callers of the alloc hooks are switched to using IS_ERR(), rather than checking for NULL. Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx> Reviewed-by: George Dunlap <george.dunlap@xxxxxxxxxx> Acked-by: Meng Xu <mengxu@xxxxxxxxxxxxx> Reviewed-by: Dario Faggioli <dfaggioli@xxxxxxxx> For bisection revision-tuple graph see: http://logs.test-lab.xenproject.org/osstest/results/bisect/xen-unstable-smoke/build-arm64-xsm.xen-build.html Revision IDs in each graph node refer, respectively, to the Trees above. ---------------------------------------- Running cs-bisection-step --graph-out=/home/logs/results/bisect/xen-unstable-smoke/build-arm64-xsm.xen-build --summary-out=tmp/120335.bisection-summary --basis-template=120304 --blessings=real,real-bisect xen-unstable-smoke build-arm64-xsm xen-build Searching for failure / basis pass: 120334 fail [host=laxton1] / 120304 ok. Failure / basis pass flights: 120334 / 120304 Tree: qemuu git://xenbits.xen.org/qemu-xen.git Tree: xen git://xenbits.xen.org/xen.git Latest a19f3519ed720f103b56dc2969993a60e76ee3f1 c9bd8a73656d7435b1055ee8825823aee995993e Basis pass a19f3519ed720f103b56dc2969993a60e76ee3f1 8b022d0005d5b941cd078f640cae04711f5536c1 Generating revisions with ./adhoc-revtuple-generator git://xenbits.xen.org/qemu-xen.git#a19f3519ed720f103b56dc2969993a60e76ee3f1-a19f3519ed720f103b56dc2969993a60e76ee3f1 git://xenbits.xen.org/xen.git#8b022d0005d5b941cd078f640cae04711f5536c1-c9bd8a73656d7435b1055ee8825823aee995993e Loaded 1001 nodes in revision graph Searching for test results: 120313 fail a19f3519ed720f103b56dc2969993a60e76ee3f1 c9bd8a73656d7435b1055ee8825823aee995993e 120304 pass a19f3519ed720f103b56dc2969993a60e76ee3f1 8b022d0005d5b941cd078f640cae04711f5536c1 120315 pass a19f3519ed720f103b56dc2969993a60e76ee3f1 8b022d0005d5b941cd078f640cae04711f5536c1 120316 fail a19f3519ed720f103b56dc2969993a60e76ee3f1 c9bd8a73656d7435b1055ee8825823aee995993e 120317 fail a19f3519ed720f103b56dc2969993a60e76ee3f1 c9bd8a73656d7435b1055ee8825823aee995993e 120322 pass a19f3519ed720f103b56dc2969993a60e76ee3f1 27254e45b102e933ec9b4fb630b384b708301095 120321 fail a19f3519ed720f103b56dc2969993a60e76ee3f1 c9bd8a73656d7435b1055ee8825823aee995993e 120325 fail a19f3519ed720f103b56dc2969993a60e76ee3f1 c3715dd8fb766eb6f90d9cd81ef892f917845238 120328 fail a19f3519ed720f103b56dc2969993a60e76ee3f1 340edc3902c1757a0e1f4391930366fb25a05df3 120330 pass a19f3519ed720f103b56dc2969993a60e76ee3f1 27254e45b102e933ec9b4fb630b384b708301095 120329 fail a19f3519ed720f103b56dc2969993a60e76ee3f1 c9bd8a73656d7435b1055ee8825823aee995993e 120331 fail a19f3519ed720f103b56dc2969993a60e76ee3f1 340edc3902c1757a0e1f4391930366fb25a05df3 120333 pass a19f3519ed720f103b56dc2969993a60e76ee3f1 27254e45b102e933ec9b4fb630b384b708301095 120334 fail a19f3519ed720f103b56dc2969993a60e76ee3f1 c9bd8a73656d7435b1055ee8825823aee995993e 120335 fail a19f3519ed720f103b56dc2969993a60e76ee3f1 340edc3902c1757a0e1f4391930366fb25a05df3 Searching for interesting versions Result found: flight 120304 (pass), for basis pass Result found: flight 120313 (fail), for basis failure Repro found: flight 120315 (pass), for basis pass Repro found: flight 120316 (fail), for basis failure 0 revisions at a19f3519ed720f103b56dc2969993a60e76ee3f1 27254e45b102e933ec9b4fb630b384b708301095 No revisions left to test, checking graph state. Result found: flight 120322 (pass), for last pass Result found: flight 120328 (fail), for first failure Repro found: flight 120330 (pass), for last pass Repro found: flight 120331 (fail), for first failure Repro found: flight 120333 (pass), for last pass Repro found: flight 120335 (fail), for first failure *** Found and reproduced problem changeset *** Bug is in tree: xen git://xenbits.xen.org/xen.git Bug introduced: 340edc3902c1757a0e1f4391930366fb25a05df3 Bug not present: 27254e45b102e933ec9b4fb630b384b708301095 Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/120335/ commit 340edc3902c1757a0e1f4391930366fb25a05df3 Author: Andrew Cooper <andrew.cooper3@xxxxxxxxxx> Date: Tue Feb 27 16:48:19 2018 +0000 xen/sched: Improvements to the {alloc,free}_domdata() interfaces The main purpose of this change is for the subsequent cleanup it enables, but it stands on its own merits. In principle, these hooks are optional, but the SCHED_OP() default aliases a memory allocation failure, which causes arinc653 to play the dangerous game of passing its priv pointer back, and remembering not to actually free it. Redefine alloc_domdata to use ERR_PTR() for errors, NULL for nothing, and non-NULL for a real allocation, which allows the hook to become properly optional. Redefine free_domdata to be idempotent. For arinc653, this means the dummy hooks can be dropped entirely. For the other schedulers, this means returning ERR_PTR(-ENOMEM) instead of NULL for memory allocation failures, and modifying the free hooks to cope with a NULL pointer. While making the alterations, drop some spurious casts to void *. Introduce and use proper wrappers for sched_{alloc,free}_domdata(). These are strictly better than SCHED_OP(), as the source code is visible to grep/cscope/tags, the generated code is better, and there can be proper per-hook defaults and checks. Callers of the alloc hooks are switched to using IS_ERR(), rather than checking for NULL. Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx> Reviewed-by: George Dunlap <george.dunlap@xxxxxxxxxx> Acked-by: Meng Xu <mengxu@xxxxxxxxxxxxx> Reviewed-by: Dario Faggioli <dfaggioli@xxxxxxxx> Revision graph left in /home/logs/results/bisect/xen-unstable-smoke/build-arm64-xsm.xen-build.{dot,ps,png,html,svg}. ---------------------------------------- 120335: tolerable ALL FAIL flight 120335 xen-unstable-smoke real-bisect [real] http://logs.test-lab.xenproject.org/osstest/logs/120335/ Failures :-/ but no regressions. Tests which did not succeed, including tests which could not be run: build-arm64-xsm 6 xen-build fail baseline untested jobs: build-arm64-xsm fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxxx https://lists.xenproject.org/mailman/listinfo/xen-devel
|
 |
Lists.xenproject.org is hosted with RackSpace, monitoring our |