Re: [Xen-devel] [PATCH v6 1/9] x86/mm: add pv prefix to {alloc, free}_page_type

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 13.02.18 at 21:04, <wei.liu2@xxxxxxxxxx> wrote:
> The two functions are only used by PV code paths because:
> 
> 1. To allocate a PGT_l*_page_table type page, a DomU must explicitly
>    request such types via PV MMU hypercall.
> 2. PV Dom0 builder explicitly asks for PGT_l*_page_table type pages,
>    but it is obviously PV only.
> 3. p2m_alloc_ptp explicitly sets PGT_l1_page_table, but the allocation
>    and deallocation of such pages don't go through the two functions
>    touched in this patch.
> 4. shadow_enable explicitly sets PGT_l2_page_table, but the allocation
>    and deallocation of such pages don't go through the two functions
>    touched in this patch.
> 
> Also move the declarations to pv/mm.h. The code will be moved later.
> Take the chance to change preemptible to bool.
> 
> Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>
> ---
>  xen/arch/x86/domain.c       |  2 +-
>  xen/arch/x86/mm.c           | 14 +++++++-------
>  xen/include/asm-x86/mm.h    |  3 ---
>  xen/include/asm-x86/pv/mm.h | 11 +++++++++++

Oh, btw - why not xen/arch/x86/pv/mm.h?

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel